Install-DbaMaintenanceSolution: change Compress/Verify/CheckSum to ValidateSet string params

[andreasjordan]

Fixes #10183.

Changed -Compress, -Verify, and -CheckSum from [switch] to [string] parameters with [ValidateSet('Default', 'ForceOn', 'ForceOff', 'Remove')].

Default = leave Ola's job text unchanged (Verify='Y', Checksum='Y', no Compress)
ForceOn = explicitly set parameter to 'Y'
ForceOff = explicitly set parameter to 'N'
Remove = strip the parameter from job text entirely

Generated with Claude Code

[ReeceGoding]

Looks mostly good. My objections are fairly minor. My only major objection is the lack of test coverage. Specifically, only ForceOn and ForceOff explicitly appear in the tests.

I would also like to import whatever we can from #10184, but converting that to use the new strings will be tedious.

[andreasjordan]

Ok, I will try and see if Claude can help here tomorrow.

[andreasjordan]

@claude are you able to read #10184 and modify and implement those tests here?

[claude]

Claude finished @andreasjordan's task in 4m 8s —— View job

---

Tasks

• Gather context
• Read current test file and implementation
• Add new test contexts for Default and Remove parameter values
• Commit and push changes

---

I added two new integration test contexts to cover the previously untested Default and Remove values for Compress, Verify, and CheckSum.

Note: I couldn't directly access PR #10184 (WebFetch/gh CLI not available), but based on the reviewer's feedback and the implementation, the missing test coverage was clearly Default and Remove.

New context: "Additional backup parameters with Default values"

Installs with no Compress/Verify/CheckSum specified (all default to 'Default'). Verifies:

• @Compress does not appear (instance-level compression setting applies)
• @Verify = 'Y' is present (Ola's default)
• @CheckSum = 'Y' is present (Ola's default)

New context: "Additional backup parameters all removed"

Installs with Compress='Remove', Verify='Remove', CheckSum='Remove'. Verifies:

• @Compress does not appear
• @Verify does not appear
• @CheckSum does not appear
  |

[andreasjordan]

@ReeceGoding Claude can not read your test PR. But if you like you can just get the code changes from this pull request and implment it in your fork and open a new pull requst. Or you can paste some of the tests here as a comment and Claude can read them.

[ReeceGoding]

On review, there isn't much left to add. All that is left is to ask Claude to add a context for "Defaults for unspecified parameters are as documentation says" . This context should include this

            $splatInstall = @{
                SqlInstance      = $TestConfig.InstanceMulti2
                # We could test that the default database is master,
                # but that is currently enforced at the PowerShell level
                # so it could just be a unit test.
                Database         = $testDbName
                InstallJobs      = $true
                ReplaceExisting  = $true
                AutoScheduleJobs = "WeeklyFull"
            }
            $installResult = Install-DbaMaintenanceSolution @splatInstall

and test for: Verify='Y', Checksum='Y', and no Compress. Don't forget

        It "Should have StartTime set to 011500 in backup schedule" {
            if (-not $script:installationSucceeded) {
                Set-ItResult -Skipped -Because "Installation failed"
                return
            }
            $schedule = Get-DbaAgentSchedule -SqlInstance $TestConfig.InstanceMulti2
            # We do not make any promises about job names,
            # so checking for times is all we can do.
            $schedule.ActiveStartTimeOfDay |
                Where-Object { $_.Hours -eq 1 -and $_.Minutes -eq 15 } |
                Should -Not -BeNullOrEmpty
        }

and

        It "Should have BackupLocation parameter set to instance default in backup jobs" {
            if (-not $script:installationSucceeded) {
                Set-ItResult -Skipped -Because "Installation failed"
                return
            }
            $splatJobStep = @{
                SqlInstance = $TestConfig.InstanceMulti2
                Job         = "DatabaseBackup - USER_DATABASES - FULL"
            }
            $jobStep = Get-DbaAgentJobStep @splatJobStep
            $backupLocationSetting = (Get-DbaDefaultPath -SqlInstance $TestConfig.InstanceMulti2).Backup
            $jobStep.Command | Should -BeLike "*@Directory = *$backupLocationSetting*"
        }

[andreasjordan]

@claude please implement the tests that @ReeceGoding suggested.

[claude]

Claude finished @andreasjordan's task in 3m 2s —— View job

---

Tasks

• Gather context
• Read current test file
• Add "Defaults for unspecified parameters" context with ReeceGoding's suggested tests
• Commit and push changes

---

Added the "Defaults for unspecified parameters are as documentation says" context to tests/Install-DbaMaintenanceSolution.Tests.ps1 with all 5 tests suggested by @ReeceGoding:

1. No Compress — verifies @Compress does not appear when parameter is omitted
2. Verify='Y' — verifies Ola's default @Verify = 'Y' is present
3. CheckSum='Y' — verifies Ola's default @CheckSum = 'Y' is present
4. StartTime 011500 — verifies a schedule with start time 01:15 exists when using AutoScheduleJobs = "WeeklyFull"
5. BackupLocation = instance default — verifies @Directory is set to the instance's default backup path

The install for this context uses AutoScheduleJobs = "WeeklyFull" (no explicit Compress/Verify/CheckSum), matching ReeceGoding's suggested splat exactly (including the preserved comments about Database).

[ReeceGoding]

I think that's everything?