Skip to content

Redesign chart widget settings dialog #3089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 7, 2025
Merged

Redesign chart widget settings dialog #3089

merged 6 commits into from
Nov 7, 2025
+410 −254

Conversation

@DaryaLari
Copy link
Contributor

@DaryaLari DaryaLari commented Nov 1, 2025

No description provided.

@github-actions
Copy link

github-actions bot commented Nov 1, 2025 •
edited
Loading

📦 Statoscope quick diff with main-branch:

⏱ Build time: 862 ms (1.56%)

⚖️ Initial size: 0.71 kb (0.02%)

🕵️ Validation errors: 0

Full Statoscope report could be found here ↗️

@github-actions
Copy link

github-actions bot commented Nov 1, 2025 •
edited
Loading

E2E Tests No Auth

Playwright test results

passed  183 passed
flaky  6 flaky
skipped  2 skipped

Details

stats  191 tests across 106 suites
duration  3 minutes, 18 seconds
commit  1b87cb0

Flaky tests

opensource › opensource-suites/dash/selectors/autoupdateRelatedSelectors.test.ts › Dashboards - Autoupdate options of group selectors › Dataset selectors don't affect each other before applying when auto-update is disabled
opensource › opensource-suites/wizard/visualizations/line/preview.test.ts › Wizard › Line chart › Event "chart-preview.error" is triggered for chart with no data
opensource › opensource-suites/wizard/visualizations/pie/markup.test.ts › Wizard › Pie chart › Markup with special characters in dataLabels @screenshot
opensource › opensource-suites/wizard/visualizations/pivot-table/drag-n-drop.test.ts › Wizard › Pivot table › Add fields by drag-n-drop
opensource › opensource-suites/wizard/visualizations/pivot-table/export.test.ts › Wizard › Pivot table › Export to xlsx
opensource › opensource-suites/wizard/visualizations/treemap/html-in-chart.test.ts › Wizard › Treemap chart › Markdown dimension @screenshot

Skipped tests

opensource › opensource-suites/dash/revisions/revisionsList.test.ts › Dashboards - Versioning › Dashboard with a long list of revisions, checking the upload and the updated list of revisions
opensource › opensource-suites/dash/selectors/autoupdateRelatedSelectors.test.ts › Dashboards - Autoupdate options of group selectors › Manual selectors with aliases don't affect each other before applying when auto-update is disabled

🧐 Links with traces:

👉 Link with detailed report: report

🐳 Link with docker compose logs: logs

Last updated: 2025-11-06 17:27:27 MSK

@github-actions
Copy link

github-actions bot commented Nov 1, 2025 •
edited
Loading

E2E Tests

Playwright test results

passed  181 passed
flaky  8 flaky
skipped  2 skipped

Details

stats  191 tests across 106 suites
duration  3 minutes, 18 seconds
commit  1b87cb0

Flaky tests

opensource › opensource-suites/wizard/fields/field-actions.test.ts › Wizard › Fields › Duplicate field
opensource › opensource-suites/wizard/visualizations/bar-y/sorting.test.ts › Wizard › Bar-y chart › Sorting by X field @screenshot
opensource › opensource-suites/wizard/visualizations/flat-table/virtualization.test.ts › Wizard › Flat table › Dynamic column width during row virtualization @screenshot
opensource › opensource-suites/wizard/visualizations/pivot-table/coloring.test.ts › Wizard › Pivot table › Custom palette bar @screenshot
opensource › opensource-suites/wizard/visualizations/pivot-table/drag-n-drop.test.ts › Wizard › Pivot table › Add fields by drag-n-drop
opensource › opensource-suites/wizard/visualizations/pivot-table/export.test.ts › Wizard › Pivot table › Export to xlsx
opensource › opensource-suites/wizard/visualizations/pivot-table/sorting.test.ts › Wizard › Pivot table › Sorting columns from the "Columns" section
opensource › opensource-suites/wizard/visualizations/pivot-table/virtualization.test.ts › Wizard › Pivot table › Correct order of rows when scrolling @screenshot

Skipped tests

opensource › opensource-suites/dash/revisions/revisionsList.test.ts › Dashboards - Versioning › Dashboard with a long list of revisions, checking the upload and the updated list of revisions
opensource › opensource-suites/dash/selectors/autoupdateRelatedSelectors.test.ts › Dashboards - Autoupdate options of group selectors › Manual selectors with aliases don't affect each other before applying when auto-update is disabled

🧐 Links with traces:

👉 Link with detailed report: report

🐳 Link with docker compose logs: logs

Last updated: 2025-11-06 17:27:41 MSK

@github-actions
Copy link

github-actions bot commented Nov 1, 2025 •
edited
Loading

E2E Tests Farm

Playwright test results

passed  418 passed
flaky  7 flaky
skipped  1 skipped

Details

stats  426 tests across 171 suites
duration  4 minutes, 44 seconds
commit  1b87cb0

Flaky tests

basic › suites/charts/export/forbiddenExport.test.ts › Chart export availability › Wizard with forbidden export › Export menu item is disabled if export is forbidden on dataset
basic › suites/charts/export/forbiddenExport.test.ts › Chart export availability › Preview with forbidden export › Wizard preview - Export menu item is disabled if export is forbidden on dataset
basic › suites/charts/export/forbiddenExport.test.ts › Chart export availability › Preview with forbidden export › Ql preview - Export menu item is disabled if export is forbidden on connection
basic › suites/dash/mobile/mobileDash.test.ts › Dashboards - mobile version on Galaxy S8 › The selector is successfully opened by a pop-up component from below
basic › suites/dataset/parameters/parameterDialogValidation.test.ts › Datasets - Parameter dialog validation › Required fields validation
basic › suites/dataset/parameters/parameterDialogValidation.test.ts › Datasets - Parameter dialog validation › Parameter name validation
basic › suites/dataset/parameters/parameterDialogValidation.test.ts › Datasets - Parameter dialog validation › Parameter default_value validation [number]

Skipped tests

basic › suites/wizard/combined-chart/layers-and-multidatasets.test.ts › Multi-faceted charts with layers › The data on the X-axis must be formed correctly from two datasets

👉 Link with detailed report: report

Last updated: 2025-11-06 17:31:41 MSK

@datalens-weblate-robot
Copy link
Contributor

datalens-weblate-robot commented Nov 1, 2025

i18n-check

The following components have not been translated

dash.widget-dialog.edit (ru)
dash.widget-dialog.edit (en)

Wait for the reviewers to check your changes in Weblate and try running github action again.

@datalens-weblate-robot
Copy link
Contributor

datalens-weblate-robot commented Nov 5, 2025

i18n-check

The following components have not been translated

dash.widget-dialog.edit (ru)
dash.widget-dialog.edit (en)

Wait for the reviewers to check your changes in Weblate and try running github action again.

@DaryaLari DaryaLari requested a review from Alutery November 5, 2025 15:02
@datalens-weblate-robot
Copy link
Contributor

datalens-weblate-robot commented Nov 5, 2025

i18n-check

The following components have not been translated

dash.widget-dialog.edit (ru)
dash.widget-dialog.edit (en)

Wait for the reviewers to check your changes in Weblate and try running github action again.

@DaryaLari DaryaLari marked this pull request as draft November 5, 2025 15:40
@DaryaLari DaryaLari marked this pull request as ready for review November 6, 2025 08:49
@datalens-weblate-robot
Copy link
Contributor

datalens-weblate-robot commented Nov 6, 2025

i18n-check

The following components have not been translated

dash.widget-dialog.edit (ru)
dash.widget-dialog.edit (en)

Wait for the reviewers to check your changes in Weblate and try running github action again.

@Alutery
Copy link
Contributor

Alutery commented Nov 6, 2025 •
edited
Loading

Here the buttons for the parameters don't quite fit with the new width:

image image

Alutery
Alutery requested changes Nov 6, 2025
View reviewed changes
@datalens-weblate-robot
Copy link
Contributor

datalens-weblate-robot commented Nov 6, 2025

i18n-check

The following components have not been translated

dash.widget-dialog.edit (ru)
dash.widget-dialog.edit (en)

Wait for the reviewers to check your changes in Weblate and try running github action again.

@DaryaLari DaryaLari marked this pull request as draft November 6, 2025 14:10
@DaryaLari DaryaLari marked this pull request as ready for review November 6, 2025 14:22
@datalens-weblate-robot
Copy link
Contributor

datalens-weblate-robot commented Nov 6, 2025

i18n-check

The following components have not been translated

dash.widget-dialog.edit (ru)
dash.widget-dialog.edit (en)

Wait for the reviewers to check your changes in Weblate and try running github action again.

@DaryaLari DaryaLari requested a review from Alutery November 6, 2025 15:00
@DaryaLari DaryaLari merged commit 030e37c into main Nov 7, 2025
16 of 17 checks passed
@DaryaLari DaryaLari deleted the CHARTS-11977 branch November 7, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Alutery Alutery Alutery approved these changes

Assignees

No one assigned

Labels

changelog component/dashboards type/chore

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DaryaLari @datalens-weblate-robot @Alutery