Skip to content

Dynamic height of placeholders in the wizard #2937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Dynamic height of placeholders in the wizard #2937

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7b686f5
Dynamic height of placeholders in the wizard
kuzmadom Sep 29, 2025
3dfd474
Merge branch 'main' of github.com:datalens-tech/datalens-ui into CHAR…
kuzmadom Oct 3, 2025
8358750
fix
kuzmadom Oct 3, 2025
1233437
Merge branch 'main' into CHARTS-11862
kuzmadom Oct 3, 2025
cb9f76a
Merge branch 'main' into CHARTS-11862
kuzmadom Oct 6, 2025
174ca5a
Merge branch 'main' into CHARTS-11862
kuzmadom Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ui/units/wizard/components/DND/DNDContainer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ class DNDContainer extends Component<DNDContainerProps, DNDContainerState> {
></div>
}
{items.map((item, index) => {
const itemClassName = item.disabled ? b('item', {short: true}) : '';
const itemClassName = b('item', item.disabled ? {short: true} : {});
return (
<div className={itemClassName} key={`${item.id}-${index}`}>
<DNDItem
Expand Down
1 change: 0 additions & 1 deletion src/ui/units/wizard/containers/App.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
}

.dnd-container {
min-height: 53px;
padding-top: 8px;

.item-icon {
Expand Down
11 changes: 7 additions & 4 deletions src/ui/units/wizard/containers/Wizard/SectionVisualization/SectionVisualization.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,10 +82,9 @@

.subcontainer {
border-bottom: 1px solid var(--g-color-line-generic);
min-height: 90px;

.subheader {
margin-bottom: 11px;
margin-bottom: var(--g-spacing-2);
display: flex;
align-items: center;
color: var(--g-color-text-complementary);
Expand Down Expand Up @@ -128,15 +127,18 @@
.dnd-container {
margin: 2px;
border-radius: 4px;
padding: 13px 17px var(--g-spacing-3);
min-height: 90px;
padding: var(--g-spacing-3) var(--g-spacing-3) var(--g-spacing-1);
border: solid 1px transparent;

.item-icon {
display: inline-block;
margin-right: 8px;
}

&__item:last-child {
margin-bottom: var(--g-spacing-2);
}

&__item_short {
align-items: center;
display: flex;
Expand Down Expand Up @@ -168,6 +170,7 @@
background: var(--g-color-base-generic);
border: 1px dashed var(--g-color-line-generic-active);
border-radius: 4px;
padding-bottom: var(--g-spacing-3);
}
}

Expand Down
Loading