BF: docker adapter: Don't couple 'run -i' with stdin.isatty #142
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
24af27f (BF: docker adapter: Drop -it flags when stdin is not a tty,
2019-11-11) dropped both --interactive and --tty from the 'docker run'
call if stdin.isatty() reports false, avoiding an "the input device is
not a TTY" failure in this case.
However, dropping --interactive shouldn't be necessary, and doing so
prevents the command from receiving stdin.
I noticed this issue when looking into gh-123.
Before this PR:
After: