Skip to content

Commit 0cd58c9

Browse files
authored
Merge pull request #45 from yambottle/master
DEV-614 remove announcement popup | include singleuser build and push GHA
2 parents 9e6b7a3 + 855c16f commit 0cd58c9

File tree

6 files changed

+30
-13
lines changed

6 files changed

+30
-13
lines changed
+16-6
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: singleuser-relase-wip
1+
name: singleuser-relase
22
on:
33
workflow_dispatch:
44
inputs:
@@ -7,22 +7,32 @@ on:
77
default: '4.0.2'
88
type: choice
99
options:
10+
- '5.0.0'
1011
- '4.0.2'
11-
- '1.4.2'
12+
1213
jobs:
1314
release-image:
1415
runs-on: ubuntu-latest
1516
strategy:
1617
matrix:
1718
include:
1819
# following python version end of life: https://devguide.python.org/versions/
20+
- py_ver: '3.11'
1921
- py_ver: '3.10'
2022
- py_ver: '3.9'
2123
- py_ver: '3.8'
2224
env:
23-
PY_VER: ${{matrix.py_ver}}
24-
JUPYTERHUB_VER: ${{github.event.inputs.jupyterhub_version}}
25+
PYTHON_VERSION: ${{matrix.py_ver}}
26+
JUPYTERHUB_VERSION: ${{github.event.inputs.jupyterhub_version}}
2527
steps:
2628
- uses: actions/checkout@v4
27-
# TODO - use docker build action
28-
# TODO - use conventional commit action to make release and changelog
29+
- name: Login to Docker Hub
30+
uses: docker/login-action@v2
31+
with:
32+
username: ${{secrets.DOCKERHUB_USERNAME}}
33+
password: ${{secrets.DOCKERHUB_TOKEN}}
34+
- run: |
35+
cd singleuser
36+
docker compose build
37+
export IMAGE_TAG=$(eval "echo \"$(cat docker-compose.yaml | grep image: | awk '{ print $2 }' | grep singleuser)\"")
38+
docker push $IMAGE_TAG

singleuser/Dockerfile

+3-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,9 @@ RUN \
1616
&& cp /tmp/config/before_start_hook.sh /usr/local/bin/before-notebook.d/ \
1717
&& chmod +x /usr/local/bin/before-notebook.d/before_start_hook.sh \
1818
# Add jupyter*config*.py
19-
&& cp /tmp/config/jupyter*config*.py /etc/jupyter/
19+
&& cp /tmp/config/jupyter*config*.py /etc/jupyter/ \
20+
&& mkdir /etc/jupyter/labconfig/ \
21+
&& cp /tmp/config/*.json /etc/jupyter/labconfig/
2022

2123
USER $NB_UID
2224
RUN \

singleuser/config/jupyter_server_config.py

+4-4
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ def scrub_output_pre_save(model, **kwargs):
8888
"JUPYTER_FILE_CONTENTS_MANAGER_ROOT_DIR", "/home/jovyan"
8989
)
9090

91-
## Jupyter collaboration extension
92-
c.YDocExtension.disable_rtc = (
93-
os.getenv("JUPYTER_YDOCEXTENSION_DISABLE_RTC", "FALSE").upper() == "TRUE"
94-
)
91+
# ## Jupyter collaboration extension
92+
# c.YDocExtension.disable_rtc = (
93+
# os.getenv("JUPYTER_YDOCEXTENSION_DISABLE_RTC", "FALSE").upper() == "TRUE"
94+
# )

singleuser/config/page_config.json

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
{
2+
"disabledExtensions": {
3+
"@jupyterlab/apputils-extension:announcements": true
4+
}
5+
}
+1-1
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
gh
2-
jupyter-collaboration
2+
# jupyter-collaboration

singleuser/docker-compose.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ services:
1010
container_name: djlabhub-singleuser
1111
env_file: .env
1212
ports:
13-
- $JUPYTER_SERVER_APP_PORT:$JUPYTER_SERVER_APP_PORT
13+
- ${JUPYTER_SERVER_APP_PORT:-8889}:${JUPYTER_SERVER_APP_PORT:-8889}
1414
volumes:
1515
- ./config/before_start_hook.sh:/usr/local/bin/before-notebook.d/before_start_hook.sh
1616
- ./config/jupyter_server_config.py:/etc/jupyter/jupyter_server_config.py

0 commit comments

Comments
 (0)