Skip to content

use a preset for excel encryption password [SC-SC-203035] #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: feature/dss12-sc-180306-ability-to-read-write-protected-excel-files
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions custom-recipes/send-mails-from-contacts-dataset/recipe.json
Original file line number Diff line number Diff line change
Expand Up @@ -205,11 +205,12 @@
},

{
"name": "encryption_password_excel",
"label" : "Encryption password",
"type": "PASSWORD",
"description" : "(Optional) Password to encrypt excel files, requires DSS 13.0 or above",
"visibilityCondition" : "model.attachment_type == 'excel_can_ac'"
"name": "encryption_password_excel_params",
"label": "Encryption password",
"type": "PRESET",
"parameterSetId": "file-encryption",
"description" : "(Optional) Password to encrypt excel files, requires DSS 13.2 or above.",
"visibilityCondition" : "model.attachment_type == 'excel_can_ac'"
},

{
Expand Down
5 changes: 4 additions & 1 deletion custom-recipes/send-mails-from-contacts-dataset/recipe.py
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,10 @@ def does_channel_have_sender(channel_id):
channel_has_sender = does_channel_have_sender(mail_channel)

attachment_type = config.get('attachment_type', "send_no_attachments")
encryption_password_excel = config.get('encryption_password_excel', None)
encryption_password_excel_params = config.get('encryption_password_excel_params', None)
encryption_password_excel = None
if encryption_password_excel_params:
encryption_password_excel = encryption_password_excel_params.get("password", None)

# Validation part 1 - Check some kind of value/column exists for body, subject, sender and recipient

Expand Down
17 changes: 17 additions & 0 deletions parameter-sets/file-encryption/parameter-set.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
{
"meta" : {
"label": "Encryption password",
"description": "Encryption password for attachment files",
"icon": "icon-pi-system icon-cogs"
},
"defaultDefinableInline": false,
"defaultDefinableAtProjectLevel": false,
"params": [
{
"name": "password",
"label": "File encryption password",
"type": "PASSWORD",
"description": "Password to encrypt attachment files. CAUTION: the password entered here is only stored encrypted when defined in a preset."
}
]
}