Skip to content

Support for volumes in AWS and GCP #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support for volumes in AWS and GCP #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion dss-docker/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ RUN R --slave --no-restore \

# Entry point
WORKDIR /home/dataiku
USER dataiku
Copy link

@jbelafa jbelafa Jan 16, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please try to avoid as much as possible execution of run.sh as root
In theDockerFile permissions are already enforced for the data directory
If it's a cloud provider level permission issue we should consider that enforcing container level related permissions must fix the problem.

You can also fork the DockerFile if you are willing to handle a EBS (or equivalent ) within docker image definition.


COPY run.sh /home/dataiku/

Expand Down
11 changes: 7 additions & 4 deletions dss-docker/run.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,13 @@
DSS_INSTALLDIR="/home/dataiku/dataiku-dss-$DSS_VERSION"

if [ ! -f "$DSS_DATADIR"/bin/env-default.sh ]; then
echo "Changing the owner of $DSS_DATADIR"
chown dataiku:dataiku "$DSS_DATADIR"

# Initialize new data directory
"$DSS_INSTALLDIR"/installer.sh -d "$DSS_DATADIR" -p "$DSS_PORT"
"$DSS_DATADIR"/bin/dssadmin install-R-integration
echo "dku.registration.channel=docker-image" >>"$DSS_DATADIR"/config/dip.properties
su dataiku -c "$DSS_INSTALLDIR/installer.sh -d $DSS_DATADIR -p $DSS_PORT"
su dataiku -c "$DSS_DATADIR/bin/dssadmin install-R-integration"
su dataiku -c 'echo "dku.registration.channel=docker-image" >>"$DSS_DATADIR"/config/dip.properties'

elif [ $(bash -c 'source "$DSS_DATADIR"/bin/env-default.sh && echo "$DKUINSTALLDIR"') != "$DSS_INSTALLDIR" ]; then
# Upgrade existing data directory
Expand All @@ -15,4 +18,4 @@ elif [ $(bash -c 'source "$DSS_DATADIR"/bin/env-default.sh && echo "$DKUINSTALLD

fi

exec "$DSS_DATADIR"/bin/dss run
su dataiku -c 'exec "$DSS_DATADIR"/bin/dss run'