-
Notifications
You must be signed in to change notification settings - Fork 3.2k
feat(search): unified entity index #14966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
david-leifker
wants to merge
9
commits into
master
Choose a base branch
from
unified-entity-index
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Meticulous spotted 0 visual differences across 964 screens tested: view results. Meticulous evaluated ~8 hours of user flows against your PR. Expected differences? Click here. Last updated for commit 35bf515. This comment will update as new commits are pushed. |
Bundle ReportBundle size has no change ✅ |
# Conflicts: # datahub-upgrade/src/main/java/com/linkedin/datahub/upgrade/loadindices/LoadIndices.java # datahub-upgrade/src/main/java/com/linkedin/datahub/upgrade/loadindices/LoadIndicesArgs.java # datahub-upgrade/src/main/java/com/linkedin/datahub/upgrade/loadindices/LoadIndicesIndexManager.java # datahub-upgrade/src/main/java/com/linkedin/datahub/upgrade/loadindices/LoadIndicesStep.java # datahub-upgrade/src/main/java/com/linkedin/datahub/upgrade/loadindices/config/LoadIndicesConfig.java # datahub-upgrade/src/test/java/com/linkedin/datahub/upgrade/UpgradeCliApplicationTestConfiguration.java # datahub-upgrade/src/test/java/com/linkedin/datahub/upgrade/loadindices/LoadIndicesIndexManagerTest.java # datahub-upgrade/src/test/java/com/linkedin/datahub/upgrade/loadindices/LoadIndicesStepTest.java # datahub-upgrade/src/test/java/com/linkedin/datahub/upgrade/loadindices/config/LoadIndicesConfigTest.java # docs/how/load-indices.md # metadata-io/src/main/java/com/linkedin/metadata/search/elasticsearch/indexbuilder/ESIndexBuilder.java # metadata-io/src/main/java/com/linkedin/metadata/search/elasticsearch/update/BulkListener.java # metadata-io/src/main/java/com/linkedin/metadata/search/elasticsearch/update/ESBulkProcessor.java # metadata-io/src/main/java/com/linkedin/metadata/search/elasticsearch/update/ESWriteDAO.java # metadata-io/src/main/java/com/linkedin/metadata/service/UpdateIndicesService.java # metadata-io/src/testFixtures/java/io/datahubproject/test/search/BulkProcessorTestUtils.java # metadata-service/factories/src/main/java/com/linkedin/gms/factory/common/RestHighLevelClientFactory.java
Supports: v2/v3 index management v3 settings/mappings Dual v2/v3 writes Not including: query
bbc4123
to
af40867
Compare
fix misssing break
228dd82
to
35bf515
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
devops
PR or Issue related to DataHub backend & deployment
docs
Issues and Improvements to docs
needs-review
Label for PRs that need review from a maintainer.
product
PR or Issue related to the DataHub UI/UX
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a new unified entity index which consolidates entity indices (100+) into a few indices. It will eventually also replace the system metadata index. This is disabled by default and only contains code for the write path at this time.
Major Features
Key Components Added
MultiEntityMappingsBuilder
- Unified mapping generationUpdateIndicesV2Strategy
&UpdateIndicesV3Strategy
- Index update strategiesSearchableAnnotationValidator
- Validation for search annotationsDelegatingMappingsBuilder
&DelegatingSettingsBuilder
- Delegation patternsConfiguration Changes