Skip to content

Conversation

sakethvarma397
Copy link
Contributor

The filters in the Impact View doesn't preserve the original encoding of the url params
3%2B is decoded to 3+ and then encoded again into a string. And by default this encoding converts the + to space, making it 3%20 . This breaks the API as we pass "3 " as argument.
Fixing that in this PR

Copy link

alwaysmeticulous bot commented Oct 9, 2025

✅ Meticulous spotted 0 visual differences across 950 screens tested: view results.

Meticulous evaluated ~8 hours of user flows against your PR.

Expected differences? Click here. Last updated for commit 1c1b49e. This comment will update as new commits are pushed.

Copy link

codecov bot commented Oct 9, 2025

Bundle Report

Changes will increase total bundle size by 20 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
datahub-react-web-esm 28.59MB 20 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js 20 bytes 18.93MB 0.0%

Files in assets/index-*.js:

  • ./src/app/shared/updateQueryParams.ts → Total Size: 459 bytes

@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Oct 9, 2025
Copy link

codecov bot commented Oct 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Oct 9, 2025
@sakethvarma397 sakethvarma397 merged commit 06aebfe into master Oct 10, 2025
37 checks passed
@sakethvarma397 sakethvarma397 deleted the sv--cus-6252-filter-ecoding-issue branch October 10, 2025 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending-submitter-merge product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants