Skip to content

Conversation

anshbansal
Copy link
Collaborator

@anshbansal anshbansal commented Oct 8, 2025

Otherwise we can get flooded with invalid policies that can cause these error logging

2025-10-07 20:16:05,218 [ForkJoinPool.commonPool-worker-62] ERROR c.datahub.authorization.PolicyEngine:286 - Unsupported field type PLATFORM
2025-10-07 20:18:05,002 [ForkJoinPool.commonPool-worker-20] ERROR c.datahub.authorization.PolicyEngine:286 - Unsupported field type PLATFORM
2025-10-07 20:18:05,004 [ForkJoinPool.commonPool-worker-71] ERROR c.datahub.authorization.PolicyEngine:286 - Unsupported field type PLATFORM

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Oct 8, 2025
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Oct 8, 2025
Copy link

codecov bot commented Oct 8, 2025

Bundle Report

Bundle size has no change ✅

Copy link

codecov bot commented Oct 8, 2025

Codecov Report

❌ Patch coverage is 92.50000% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ta/aspect/validation/PolicyFieldTypeValidator.java 88.88% 1 Missing and 2 partials ⚠️

📢 Thoughts on this report? Let us know!

@david-leifker
Copy link
Collaborator

We should prefer validation which works across all APIs. While this change protects GraphQL, it doesn't support OpenAPI or Restli. Implementing this logic as a standard validator allows for cross-API validation.

@datahub-cyborg datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels Oct 8, 2025
@anshbansal anshbansal marked this pull request as draft October 9, 2025 14:01
@anshbansal anshbansal force-pushed the ab-2025-oct-08-add-validation-entity-type branch from 46e5927 to d6559d5 Compare October 9, 2025 15:24
Copy link

alwaysmeticulous bot commented Oct 9, 2025

✅ Meticulous spotted 0 visual differences across 950 screens tested: view results.

Meticulous evaluated ~8 hours of user flows against your PR.

Expected differences? Click here. Last updated for commit d6559d5. This comment will update as new commits are pushed.

@anshbansal anshbansal force-pushed the ab-2025-oct-08-add-validation-entity-type branch from d6559d5 to d244b14 Compare October 10, 2025 12:24
@anshbansal anshbansal marked this pull request as ready for review October 10, 2025 13:11
@datahub-cyborg datahub-cyborg bot added needs-review Label for PRs that need review from a maintainer. and removed pending-submitter-response Issue/request has been reviewed but requires a response from the submitter labels Oct 10, 2025
AspectPluginConfig.builder()
.className(PolicyFieldTypeValidator.class.getName())
.enabled(true)
.supportedOperations(List.of(CREATE, CREATE_ENTITY, UPSERT, UPDATE, PATCH))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation doesn't appear to support patch

Copy link
Collaborator

@david-leifker david-leifker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove or implement patch support. This would involve reading the existing aspect, applying the patch and then evaluate. Use the aspectRetriever interface from opContext to fetch the current aspect..

@datahub-cyborg datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels Oct 13, 2025
@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed pending-submitter-response Issue/request has been reviewed but requires a response from the submitter labels Oct 13, 2025
@anshbansal anshbansal merged commit e4184fe into master Oct 13, 2025
45 checks passed
@anshbansal anshbansal deleted the ab-2025-oct-08-add-validation-entity-type branch October 13, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pending-submitter-merge product PR or Issue related to the DataHub UI/UX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants