Skip to content

fix: change deprecated filename key to path in example recipe #14950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: change deprecated filename key to path in example recipe #14950

wants to merge 2 commits into from

Conversation

tuliolima
Copy link

@tuliolima tuliolima commented Oct 8, 2025 •
edited
Loading

The filename key in the Metadata File source is deprecated and was replaced by path key. The example text needs to be updated.

@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata community-contribution PR or Issue raised by member(s) of DataHub Community labels Oct 8, 2025
@tuliolima tuliolima marked this pull request as draft October 8, 2025 10:29
@tuliolima tuliolima closed this Oct 8, 2025
@tuliolima tuliolima reopened this Oct 8, 2025
@tuliolima
Copy link
Author

@yoonhyejin, can you review this?

@deepgarg760 deepgarg760 requested a review from yoonhyejin October 8, 2025 10:48
@yoonhyejin yoonhyejin marked this pull request as ready for review October 8, 2025 11:46
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Oct 8, 2025
yoonhyejin
yoonhyejin approved these changes Oct 9, 2025
View reviewed changes
Copy link
Collaborator

@yoonhyejin yoonhyejin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for raising the contribution! looks good in the docs preview : https://docs-website-fdu6xlf84-acryldata.vercel.app/docs/generated/ingestion/sources/metadata-file

I'm seeing some of our CI is failing, but they're not directly related to the change. We're working on the fix internally, and will merge this as soon as the CI is green.

@datahub-cyborg datahub-cyborg bot added merge-pending-ci A PR that has passed review and should be merged once CI is green. and removed needs-review Label for PRs that need review from a maintainer. labels Oct 9, 2025
@yoonhyejin yoonhyejin added hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ hacktoberfest Targeted Issues & PRs for Hacktoberfest labels Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoonhyejin yoonhyejin yoonhyejin approved these changes

Assignees
No one assigned
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community hacktoberfest Targeted Issues & PRs for Hacktoberfest hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ ingestion PR or Issue related to the ingestion of metadata merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tuliolima @yoonhyejin @acryl-hyejin