-
Notifications
You must be signed in to change notification settings - Fork 3.2k
refactor(policy): Update policy check for get invite token and create invite token #14941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
deepgarg760
merged 7 commits into
datahub-project:master
from
DucNgoQuang:fix-policy-invite-token
Oct 10, 2025
Merged
refactor(policy): Update policy check for get invite token and create invite token #14941
deepgarg760
merged 7 commits into
datahub-project:master
from
DucNgoQuang:fix-policy-invite-token
Oct 10, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle ReportChanges will decrease total bundle size by 81 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: datahub-react-web-esmAssets Changed:
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
deepgarg760
approved these changes
Oct 8, 2025
Thanks for the contribution!! |
treff7es
pushed a commit
that referenced
this pull request
Oct 13, 2025
… invite token (#14941) Co-authored-by: Deepak Garg <[email protected]>
alplatonov
pushed a commit
to alplatonov/datahub
that referenced
this pull request
Oct 13, 2025
… invite token (datahub-project#14941) Co-authored-by: Deepak Garg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
community-contribution
PR or Issue raised by member(s) of DataHub Community
hacktoberfest
Targeted Issues & PRs for Hacktoberfest
hacktoberfest-accepted
Acceptance for hacktoberfest https://hacktoberfest.com/participation/
merge-pending-ci
A PR that has passed review and should be merged once CI is green.
product
PR or Issue related to the DataHub UI/UX
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the link, the Manage User Credentials platform permission is responsible for manage credentials for native DataHub users, including inviting new users and resetting passwords.
Current issue :
Get invite token operation and Create invite token operation check for the Manage Policies platform permission instead.
Fix :
Check for Manage User Credentials permission instead of Manage Policies permission