Skip to content

Conversation

@chriscollins3456
Copy link
Collaborator

Moves the changes to determine if a template should be editable and the settings button to their own files to separate concerns.

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Oct 3, 2025
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Oct 3, 2025
@github-actions github-actions bot requested a deployment to datahub-project-web-react (Preview) October 3, 2025 15:13 Abandoned
@alwaysmeticulous
Copy link

alwaysmeticulous bot commented Oct 3, 2025

🔴 Meticulous spotted visual differences in 1409 of 1554 screens tested: view and approve differences detected.

Meticulous evaluated ~9 hours of user flows against your PR.

Last updated for commit 268da82. This comment will update as new commits are pushed.

@codecov
Copy link

codecov bot commented Oct 3, 2025

Bundle Report

Changes will increase total bundle size by 73 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
datahub-react-web-esm 28.58MB 73 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js 73 bytes 18.92MB 0.0%

Files in assets/index-*.js:

  • ./src/app/homeV3/settings/HomePageSettingsButtonWrapper.tsx → Total Size: 59 bytes

  • ./src/app/homeV3/context/hooks/useIsTemplateEditable.ts → Total Size: 64 bytes

  • ./src/app/homeV3/context/PageTemplateContext.tsx → Total Size: 2.66kB

  • ./src/app/homeV3/HomePageContent.tsx → Total Size: 530 bytes

@codecov
Copy link

codecov bot commented Oct 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Oct 14, 2025
@chriscollins3456 chriscollins3456 merged commit e25a82a into master Oct 14, 2025
40 of 41 checks passed
@chriscollins3456 chriscollins3456 deleted the cc--update-home-page-oss-changes branch October 14, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pending-submitter-merge product PR or Issue related to the DataHub UI/UX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants