common: move profiling to its own package

common/profile.go → profiling/profiling.go

@@ -17,7 +17,7 @@
  *
  */
 
-package common
+package profiling
 
 import (
 	"log"
@@ -29,7 +29,7 @@ import (
 )
 
 // Profile start profiling loop
-func Profile() {
+func Profile(pathPrefix string) {
 	cpu := make(chan os.Signal, 1)
 	signal.Notify(cpu, syscall.SIGUSR1)
 
@@ -39,7 +39,7 @@ func Profile() {
 	for {
 		select {
 		case <-cpu:
-			f, err := os.Create("/tmp/skydive-cpu.prof")
+			f, err := os.Create(pathPrefix + "cpu.prof")
 			if err != nil {
 				log.Fatal("could not create CPU profile: ", err)
 			}
@@ -56,7 +56,7 @@ func Profile() {
 		case <-memory:
 			// Memory Profile
 			runtime.GC()
-			memProfile, err := os.Create("/tmp/skydive-memory.prof")
+			memProfile, err := os.Create(pathPrefix + "memory.prof")
 			if err != nil {
 				log.Fatal(err)
 			}

skydive_prof.go

@@ -21,11 +21,11 @@ package main
 
 import (
 	"github.com/skydive-project/skydive/cmd/skydive"
-	"github.com/skydive-project/skydive/common"
+	"github.com/skydive-project/skydive/profiling"
 )
 
 func main() {
-	go common.Profile()
+	go profiling.Profile("/tmp/skydive-")
 
 	skydive.RootCmd.Execute()
 }

tests/tests.go

@@ -47,6 +47,7 @@ import (
 	g "github.com/skydive-project/skydive/gremlin"
 	shttp "github.com/skydive-project/skydive/http"
 	"github.com/skydive-project/skydive/logging"
+	"github.com/skydive-project/skydive/profiling"
 )
 
 const (
@@ -846,7 +847,7 @@ var initStandalone = false
 
 func runStandalone() {
 	if profile {
-		go common.Profile()
+		go profiling.Profile("/tmp/skydive-test-")
 	}
 
 	server, err := analyzer.NewServerFromConfig()