Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request optimizes the container build process for the datacommons-services image. By implementing a targeted ignore file, the build process avoids uploading large, irrelevant directories to Cloud Build, resulting in faster startup times and reduced network overhead without impacting other container builds. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a target-specific .gcloudignore.cdc_services file to exclude unused subsystems (such as import/, nl_server/, deploy/nl/, tools/, and docs/) from the cdc_services container builds. It also updates the push_cdc_services_image.sh script to use this new ignore file during the gcloud builds submit process. There are no review comments, and I have no additional feedback to provide.
…dignore.cdc_services
Overview
Follow-up to #6655.
When building targeted container images such as
datacommons-servicesusingscripts/push_cdc_services_image.sh,gcloud builds submit .packages and uploads a tarball of the local workspace to Cloud Storage.Because the root
.gcloudignoreis shared across all builds, it cannot exclude subsystems required by other containers (such asimport/needed bycdc_data, ornl_server/andtools/). Consequently,push_cdc_services_image.shneedlessly uploads gigabytes of local directories (nl_server,tools,import,docs) during the Cloud BuildFETCHSOURCEstage.Changes
.gcloudignore.cdc_services:.gcloudignorevia#!include:.gcloudignore(.git,**/.venv,node_modules/, etc.).cdc_servicesnever references:import/,nl_server/,deploy/nl/,tools/, anddocs/.scripts/push_cdc_services_image.sh:--ignore-file=.gcloudignore.cdc_servicestogcloud builds submit, drastically reducing upload archive size and build startup latency without affecting any other container builds in the repository.