Skip to content

Add PR reviewer to cloudbuild configuration for NL goldens#6039

Merged
beets merged 2 commits intomasterfrom
beets-patch-2
Feb 28, 2026
Merged

Add PR reviewer to cloudbuild configuration for NL goldens#6039
beets merged 2 commits intomasterfrom
beets-patch-2

Conversation

@beets
Copy link
Collaborator

@beets beets commented Feb 27, 2026

No description provided.

@beets beets requested a review from gmechali February 27, 2026 18:31
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the automated pull request creation process within Cloud Build by ensuring that PRs generated for NL goldens are automatically assigned to a designated reviewer team. This streamlines the review workflow for these automated changes, reducing manual intervention and accelerating the integration of golden updates.

Highlights

  • Automated PR Reviewer Assignment: Introduced a new substitution variable _PR_REVIEWER in the Cloud Build configuration to automatically assign a specific team (datacommonsorg/website-reviewers) as reviewers to pull requests created for NL goldens.
  • Cloud Build Integration: Modified the gh pr create command within the Cloud Build step to utilize the newly defined _PR_REVIEWER variable, ensuring that automated PRs are created with pre-assigned reviewers.
Changelog
  • build/ci/cloudbuild.update_nl_goldens.yaml
    • Added a new substitution variable _PR_REVIEWER with the value datacommonsorg/website-reviewers.
    • Integrated the _PR_REVIEWER variable into the gh pr create command using the --reviewer flag.
    • Adjusted file formatting by removing a newline at the end of the file.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the update_nl_goldens Cloud Build configuration to automatically add the datacommonsorg/website-reviewers team as a reviewer on the pull requests it creates. The implementation correctly uses a new substitution variable and adds the --reviewer flag to the gh pr create command.

While reviewing the file, I noticed a small opportunity for improvement in the create-pr step. The command apt-get update && apt-get install -y git gh is run twice (on lines 68 and 94). The second call is redundant and could be removed to make the CI step slightly more efficient. Since this is outside the lines modified in this PR, I'm mentioning it here for your consideration for a future cleanup.

Copy link
Contributor

@gmechali gmechali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks Carolyn

@beets beets enabled auto-merge (squash) February 28, 2026 00:05
@beets beets merged commit 2f6774b into master Feb 28, 2026
9 checks passed
@beets beets deleted the beets-patch-2 branch February 28, 2026 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants