Correct stat type of gender wage gap

[kmoscoe]

This is actually the ratio of the difference between median combined earnings against median men earnings.

[gemini-code-assist]

Summary of Changes

Hello @kmoscoe, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the data model by correcting the statistical type associated with the "Gender wage gap" variable. This ensures that the metric is correctly categorized as a ratio, aligning its statType with its actual definition and improving data accuracy for downstream consumption.

Highlights

• Corrected statType for Gender Wage Gap: The statType for the "Gender wage gap" variable in custom_dc/sample/variables.mcf was updated from dcid:meanValue to dcid:Ratio. This change accurately reflects its definition as a ratio of median earnings differences.

Changelog

• custom_dc/sample/variables.mcf
  • Updated the statType for the "Gender wage gap" entry from dcid:meanValue to dcid:Ratio.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly updates the statType for the gender_wage_gap variable from dcid:meanValue to dcid:Ratio in custom_dc/sample/variables.mcf. This change accurately reflects that the variable represents a ratio, as described. Additionally, a newline has been added to the end of the file, which is a good practice. The changes are correct and improve the data definition.

[beets]

the domain for statType is property -- medianValue is the closest that we currently have (the full list is here -- look for the list of domainIncludes), or we can add something new for this.

[kmoscoe]

Yes, you're right. But it is odd that there is no ratio, percentage, difference etc. Even in go/dcguidebook we have a recommendation for percentages but no way to specifying this in the statType. Should we add these?