Fix Path Traversal Vulnerabilities

[AZborovskyyEpam]

Fix file paths constructed from user input without proper validation can allow attackers to access files outside intended directories.

[gemini-code-assist]

Summary of Changes

Hello @AZborovskyyEpam, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the security of file operations by preventing path traversal attacks. It introduces a dedicated validation mechanism for locale and filename parameters, ensuring that all file access attempts are confined to the expected directories. This change protects the system from malicious input that could otherwise lead to unauthorized file access or manipulation.

Highlights

• Security Fix: Addressed potential path traversal vulnerabilities by implementing robust validation for user-supplied locale and filename inputs.
• Path Validation Logic: Introduced a new function, get_validated_locale_path, which uses regular expressions to validate locale and filename formats and ensures paths remain within the intended base directory.
• Refactored File Operations: Updated extract_messages_from_file and write_messages functions to utilize the new get_validated_locale_path for all file path constructions, centralizing security checks.

Changelog

• tools/i18n/add_fallback_messages.py
  • Added re and pathlib.Path imports for regular expression matching and path manipulation.
  • Defined LOCALE_BASE_PATH, LOCALE_RE, and FILENAME_RE for base path definition and input validation.
  • Implemented get_validated_locale_path function to validate locale and filename inputs and prevent directory traversal.
  • Modified extract_messages_from_file to use the new get_validated_locale_path for secure path construction.
  • Modified write_messages to use the new get_validated_locale_path for secure path construction.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a robust path validation mechanism to prevent path traversal vulnerabilities when handling file paths constructed from user input. A new function, get_validated_locale_path, is added which validates locale and filename components using both regular expressions and pathlib's path resolution checks. This is a solid approach to security. My review includes a minor suggestion to improve the conciseness of the validation logic.