Fix blue-green import (undefined variables)

[jm-rivera]

The blue-green import path in latest crashes at the SQLite-to-Cloud SQL transfer step due to the undefined variables, but the job exited 0 because the top-level exception handler logged the error without re-raising. Cloud Run reported the job as successful despite the data never being transferred.

This PR

• Fixes NameError in blue-green import: obs_count, triple_count, kv_count were never defined — replaced with counts['observations'], counts['triples'], counts['key_value_store'] from the existing get_row_counts() result
• Ensures the exception in Runner.run() is re raised so import failures propagate to the process exit code instead of being silently swallowed

[gemini-code-assist]

Summary of Changes

Hello @jm-rivera, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the reliability and error reporting of the blue-green import process. It addresses critical issues where data transfer failures were not correctly reported due to undefined variables and a suppressed exception, ensuring that import jobs accurately reflect their success or failure status.

Highlights

• Blue-Green Import Fix: Resolved NameError issues during the SQLite-to-Cloud SQL transfer step in the blue-green import process by replacing undefined variables (obs_count, triple_count, kv_count) with correctly referenced values from the get_row_counts() result.
• Error Propagation: Modified the Runner.run() method to re-raise exceptions, ensuring that import failures are no longer silently swallowed and correctly propagate to the process exit code, preventing misleading success reports.

Changelog

• simple/stats/runner.py
  • Ensured exceptions caught in the run method are re-raised to propagate errors.
  • Corrected variable references for expected_obs, expected_triples, and expected_kv in the _run_local_sqlite_build_import function, using counts['observations'], counts['triples'], and counts['key_value_store'] respectively.

Activity

• No human activity has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request effectively addresses critical issues related to undefined variables in the blue-green import process and ensures that import failures are properly propagated. The changes improve the robustness and reliability of the import mechanism by preventing silent failures. The code changes are clear and directly resolve the identified problems.

[keyurva]

Thanks!