refactor(infra): deprecate namespace in favor of instance-name

[dwnoble]

Deprecates the use of the word 'namespace' for prefixing resource names in Terraform configurations and scaffolding, replacing it with the clearer term 'instance_name'. Main changes include variables, default values, validations, and documentation updates while preserving backward compatibility.

[gemini-code-assist]

Code Review

This pull request replaces the namespace variable with instance_name across the Terraform configurations, CLI, tests, and documentation to improve resource naming clarity, while maintaining backward compatibility. The review feedback recommends adding a validation block to the new instance_name variable to enforce GCP naming conventions and prevent deployment failures, as well as cleaning up several extra consecutive blank lines introduced in the Terraform files.

[gemini-code-assist]

To prevent deployment failures due to invalid resource names (e.g., containing underscores or exceeding length limits), it is highly recommended to add a validation block to var.instance_name. This ensures that any user-provided value conforms to GCP naming conventions (lowercase alphanumeric characters and dashes, up to 16 characters) when defined directly in terraform.tfvars.

variable "instance_name" {
  description = "A unique identifier used as a prefix for resource naming. This prevents naming conflicts when deploying multiple isolated environments (like dev, staging, or feature branches) within the same GCP project."
  type        = string
  default     = ""

  validation {
    condition     = var.instance_name == "" || (length(var.instance_name) <= 16 && can(regex("^[a-z]([-a-z0-9]*[a-z0-9])?$", var.instance_name)))
    error_message = "The instance_name must be 16 characters or less, start with a lowercase letter, end with a lowercase letter or number, and contain only lowercase alphanumeric characters and dashes."
  }
}

[gemini-code-assist]

Remove the extra consecutive blank lines to maintain clean and consistent Terraform formatting.

    clean_namespace_prefix         = local.clean_namespace_prefix
    enable_redis_cache_clearing    = var.enable_redis_cache_clearing

[gemini-code-assist]

Remove the extra consecutive blank lines to keep the variable definitions clean and readable.

}

variable "ingestion_helper_service_name" {

[gemini-code-assist]

Remove the extra consecutive blank lines to maintain clean and consistent formatting across module declarations.

}

module "redis" {

[gmechali]

thanks Dan!