Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce table definition #1450

Merged
merged 58 commits into from
Mar 6, 2025
Merged

Conversation

sriram251-code
Copy link
Contributor

This pull request introduces significant enhancements to the table discovery module by adding new data structures and services for geting table definitions. The changes include the creation of data classes for table and field information, the introduction of an abstract service for fetching table definitions, and a concrete implementation for T-SQL table definitions.

@sriram251-code sriram251-code self-assigned this Feb 18, 2025
@sriram251-code sriram251-code added the enhancement New feature or request label Feb 18, 2025
@sriram251-code sriram251-code marked this pull request as ready for review February 18, 2025 07:42
@sriram251-code sriram251-code requested a review from a team as a code owner February 18, 2025 07:42
Copy link

github-actions bot commented Feb 19, 2025

✅ 13/13 passed, 1 skipped, 15s total

Running from acceptance #261

@sriram251-code sriram251-code changed the base branch from main to feature/profiler_etl February 25, 2025 15:36
@gueniai gueniai added the stacked PR Should be reviewed, but not merged label Mar 5, 2025
Base automatically changed from feature/profiler_etl to main March 6, 2025 11:32
Copy link
Collaborator

@sundarshankar89 sundarshankar89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Can you fix the conflicts

…le_definition

# Conflicts:
#	src/databricks/labs/remorph/assessments/pipeline.py
#	src/databricks/labs/remorph/assessments/profiler_config.py
#	tests/integration/assessments/test_pipeline.py
#	tests/resources/assessments/pipeline_config.yml
@sundarshankar89 sundarshankar89 added this pull request to the merge queue Mar 6, 2025
Merged via the queue into main with commit 449dd2f Mar 6, 2025
6 checks passed
@sundarshankar89 sundarshankar89 deleted the feature/introduce_table_definition branch March 6, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stacked PR Should be reviewed, but not merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants