feat(marketplace): add Go to Details button to info dialog#494
Open
larsgeorge-db wants to merge 1 commit into
Open
feat(marketplace): add Go to Details button to info dialog#494larsgeorge-db wants to merge 1 commit into
larsgeorge-db wants to merge 1 commit into
Conversation
Adds an optional onGoToDetails callback to EntityInfoDialog that renders a "Go to Details" button (with the ExternalLink icon used on tiles) in the dialog footer. Wired up on the marketplace product modal so users can jump from the info preview to the full product detail page, mirroring the icon-button on the product tile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
onGoToDetailscallback prop toEntityInfoDialogand render a "Go to Details" button in the footer, using the sameExternalLinkicon as the marketplace tile's quick-link button.onSubscribeoronGoToDetailsis provided (instead of only for subscribe).onGoToDetailson the marketplace product info modal (marketplace-view.tsx) so users can jump from the preview straight to/my-products/{id}— mirroring the tile's icon button.Test plan
EntityInfoDialog(asset explorer, data products/contracts/domains views, discovery section, metadata panel) still render correctly with no footer change since they don't passonGoToDetails.