[Rust] Add is_closed method on proto/json steams#158
Open
danilonajkov-db wants to merge 3 commits intomainfrom
Open
[Rust] Add is_closed method on proto/json steams#158danilonajkov-db wants to merge 3 commits intomainfrom
danilonajkov-db wants to merge 3 commits intomainfrom
Conversation
Contributor
elenagaljak-db
left a comment
elenagaljak-db
left a comment
There was a problem hiding this comment.
I remember this method already existed at one point, not sure what happened to it...
elenagaljak-db
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
We have this method for arrow streams, but not for proto/json. It is needed for correctly handling the closure from the java side.
How is this tested?
Added this method to tests.