[Java] Add configurable IPC compression for Arrow streams#154
Open
danilonajkov-db wants to merge 4 commits intomainfrom
Open
[Java] Add configurable IPC compression for Arrow streams#154danilonajkov-db wants to merge 4 commits intomainfrom
danilonajkov-db wants to merge 4 commits intomainfrom
Conversation
danilonajkov-db
changed the title
Comment on lines
+303
to
+306
| public ArrowStreamConfigurationOptionsBuilder setIpcCompression( | ||
| IPCCompressionType ipcCompression) { | ||
| this.ipcCompression = ipcCompression; | ||
| return this; |
Contributor
There was a problem hiding this comment.
What if someone sends a null? Claude says this can happen:
sdk.createArrowStream(tableName, schema, clientId, clientSecret, options);
// throws NullPointerException deep in JNI with no useful message
If someone passes null, it gets stored and then JNI calls ordinal() on it, which throws a NullPointerException with no useful message. Worth adding a null check.
Contributor
Author
There was a problem hiding this comment.
thanks, i've set it as if null is provided it will default to no compression
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
IPCCompressionTypeenum (NONE,LZ4_FRAME,ZSTD) to configure Arrow IPC compressionipcCompressionfield toArrowStreamConfigurationOptionswith builder supportarrow_ipc::CompressionTypeHow is this tested?
Added integration tests + ran the sample client with all kinds of compressions