Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support project relative imports #40

Merged
merged 1 commit into from
Mar 9, 2024
Merged

support project relative imports #40

merged 1 commit into from
Mar 9, 2024
+15 −2

Conversation

carl-db
Copy link
Collaborator

@carl-db carl-db commented Mar 8, 2024

  • Best practice going forward is to import files relative to the project root.
  • Include bazel-bin for generated files by default.

@carl-db carl-db merged commit 473c07f into master Mar 9, 2024
0 of 2 checks passed
@carl-db
Copy link
Collaborator Author

carl-db commented Mar 9, 2024

Builds failures unrelated to PR ...

@lihaoyi-databricks how do we upload new versions?

@lihaoyi-databricks
Copy link
Contributor

@carl-db so far it's manual using my jetbrains account. Let me pull down your changes and build/package/upload one a new zip

@lihaoyi-databricks
Copy link
Contributor

I uploaded a 0.1.3 zip, should be available once it passes jetbrains review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lihaoyi-databricks lihaoyi-databricks lihaoyi-databricks approved these changes

@gabrielrussoc gabrielrussoc Awaiting requested review from gabrielrussoc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carl-db @lihaoyi-databricks