Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix File Type Factory for libsonnet #32

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rubencougil
Copy link

@rubencougil rubencougil commented Jun 25, 2021

With this fix, both jsonnet and libsonnet are working within the plugin.
Built and tested locally (with IntelliJ 2021.1.1)

With this fix, both jsonnet and libsonnet are working within the plugin.
Built and tested locally.
@bryant1410
Copy link
Contributor

@rubencougil
Copy link
Author

I wonder why this is needed. With semicolon it should work:

https://github.com/JetBrains/intellij-community/blob/cefe3d90e0d1371f05a7555e3fdbdcef2c70c647/platform/platform-api/src/com/intellij/openapi/fileTypes/FileTypeConsumer.java#L14

libsonnet is not working as it is_

Yep, according to the doc it should work, but it doesn't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants