Skip to content

SEA: add support for Hybrid disposition #631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 350 commits into from
Jul 17, 2025
Merged

Conversation

varun-edachali-dbx
Copy link
Collaborator

@varun-edachali-dbx varun-edachali-dbx commented Jul 8, 2025

What type of PR is this?

  • Feature

Description

Following discussions surrounding the inefficiency of the existing EXTERNAL_LINKS disposition due to the repeated calls made to the control plane, we introduce support for the Hybrid disposition, which provides batches of links and prevents the need to query for every link.

In case of small results, we get the response in the attachment key in the arrow format, which further boosts the efficiency.

How is this tested?

  • Unit tests
  • E2E Tests
  • Manually
  • N/A

Related Tickets & Documents

Benchmarking of EXTERNAL_LINKS
Design Doc
PECOBLR-639

This reverts commit 8bd12d8, reversing
changes made to 030edf8.
This reverts commit be1997e, reversing
changes made to 37813ba.
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
@databricks databricks deleted a comment from github-actions bot Jul 16, 2025
@databricks databricks deleted a comment from github-actions bot Jul 16, 2025
@databricks databricks deleted a comment from github-actions bot Jul 16, 2025
@databricks databricks deleted a comment from github-actions bot Jul 16, 2025
@databricks databricks deleted a comment from github-actions bot Jul 16, 2025
@databricks databricks deleted a comment from github-actions bot Jul 16, 2025
@databricks databricks deleted a comment from github-actions bot Jul 16, 2025
@databricks databricks deleted a comment from github-actions bot Jul 16, 2025
@varun-edachali-dbx varun-edachali-dbx changed the base branch from ext-links-sea to sea-migration July 16, 2025 08:26
@varun-edachali-dbx varun-edachali-dbx marked this pull request as ready for review July 16, 2025 08:27
@varun-edachali-dbx varun-edachali-dbx marked this pull request as draft July 16, 2025 08:39
Signed-off-by: varun-edachali-dbx <[email protected]>
Copy link

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

@varun-edachali-dbx varun-edachali-dbx marked this pull request as ready for review July 16, 2025 08:58
Copy link
Contributor

@jayantsing-db jayantsing-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Some minor questions, rest LGTM

Copy link

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

@varun-edachali-dbx varun-edachali-dbx merged commit 640cc82 into sea-migration Jul 17, 2025
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants