Skip to content

Treat pandas as an optional dependency (#489) #536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gs11
Copy link

@gs11 gs11 commented Mar 24, 2025

What type of PR is this?

  • Refactor
  • Feature
  • Bug Fix
  • Other

Description

This naive PR changes pandas to be an optional dependency - just like pyarrow.
Tests fail but seemingly due to unrelated things.

How is this tested?

  • Unit tests
  • E2E Tests
  • Manually
  • N/A

Related Tickets & Documents

#489

@gs11
Copy link
Author

gs11 commented Apr 11, 2025

Any chance to get this reviewed?
@deeksha-db @samikshya-db @jprakash-db @yunbodeng-db @jackyhu-db @benc-db

@FBruzzesi
Copy link

Hey @gs11 thanks for addressing this, I just realized about your PR.
To close #489 you should make sure to avoid importing pandas as top level import in src/databricks/sql/client.py. That would have been my strategy.

I really hope this gets through eventually

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Signed-off-by: Gustav Sinder <[email protected]>
@gs11 gs11 force-pushed the optional-pandas branch from ef9308e to eee08e8 Compare April 18, 2025 16:22
@gs11
Copy link
Author

gs11 commented Apr 18, 2025

To close #489 you should make sure to avoid importing pandas as top level import in src/databricks/sql/client.py. That would have been my strategy.

Thanks! @FBruzzesi I realize this change wasn't pushed properly to my branch. Updated it as well as rebased to resolve the poetry.lock conflict issues due to upstream being updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants