Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated retry timeout #497

Merged
merged 2 commits into from
Jan 31, 2025
Merged

Updated retry timeout #497

merged 2 commits into from
Jan 31, 2025

Conversation

jprakash-db
Copy link
Contributor

Description

  • Set the retry timeout to be the max of retry_after and retry_max_delay
  • Increased the retry_max_delay

@jprakash-db jprakash-db self-assigned this Jan 31, 2025
@benc-db
Copy link
Collaborator

benc-db commented Jan 31, 2025

Going to test with my local repro to verify the fix.

@benc-db
Copy link
Collaborator

benc-db commented Jan 31, 2025

Looks reasonable when I test with dbt-databricks. Can we add a debug log statement that says how long we're going to sleep for?

@jprakash-db
Copy link
Contributor Author

@benc-db Added the logging

@jprakash-db jprakash-db merged commit fc9da22 into release/3.7.2 Jan 31, 2025
1 of 3 checks passed
@jprakash-db jprakash-db mentioned this pull request Feb 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benc-db benc-db benc-db approved these changes

@jackyhu-db jackyhu-db jackyhu-db approved these changes

@rcypher-databricks rcypher-databricks Awaiting requested review from rcypher-databricks rcypher-databricks is a code owner

@yunbodeng-db yunbodeng-db Awaiting requested review from yunbodeng-db yunbodeng-db is a code owner

@andrefurlan-db andrefurlan-db Awaiting requested review from andrefurlan-db andrefurlan-db is a code owner

Assignees

@jprakash-db jprakash-db

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jprakash-db @benc-db @jackyhu-db