Remove a mypy error message workaround that should be unnecessary in mypy 1.15.0 #484
+12
−330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyattscarpenter
force-pushed
the
patch-1
branch
2 times, most recently
from
861b171 to
504d3be
Compare
v1.14.1 is the current version, and python/mypy#17485 has the "upnext" label, so 1.15 should do Signed-off-by: wyattscarpenter <[email protected]>
see python/mypy#17485 or python/mypy#10768 for more information Signed-off-by: wyattscarpenter <[email protected]>
…python 3.8 is eol'd Signed-off-by: wyattscarpenter <[email protected]>
Signed-off-by: wyattscarpenter <[email protected]>
Signed-off-by: wyattscarpenter <[email protected]>
Signed-off-by: wyattscarpenter <[email protected]>
wyattscarpenter
force-pushed
the
patch-1
branch
from
504d3be to
c0f6ca9
Compare
wyattscarpenter
requested review from
deeksha-db,
samikshya-db,
jprakash-db,
yunbodeng-db,
jackyhu-db and
benc-db
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See python/mypy#17485 or python/mypy#10768 for more information on the problem and one-net-line workaround that used to be here.
This removes a workaround for the problem addressed by "Fix --install-types masking failure details (wyattscarpenter, PR 17485)" mentioned in https://mypy.readthedocs.io/en/stable/changelog.html , which I had previously added a workaround for in the course of contributing a prior PR. (It's fine if the workaround remains in; it doesn't break anything (I think) — although future maintainers may find it a bit confusing!)
This PR drops python 3.8 support, because the fixed version of mypy drops 3.8 support, and so is only useful after this project drops 3.8 support. (Maybe that's already happened.)
While I was here, I also changed something to "poetry.group.dev.dependencies", as the poetry deprecation message suggested, which didn't seem to change anything.
I also ran
poetry lockto update the lock file, which was needed.The DCO check is currently broken, but I have signed-off all of my commits here 🙇
Appendix A: verbiage from when this was a draft PR
This pr should be good to go next time there's another release of mypy. I'm just keeping it a draft til then.(I also think I will have to run poetry lock, based on the ci. But I'lll put that off until mypy 1.15.0 is even real.)