Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prep for Test Automation #352

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Prep for Test Automation #352

merged 1 commit into from
Feb 14, 2024

Conversation

benc-db
Copy link
Collaborator

@benc-db benc-db commented Feb 13, 2024

This PR introduces a new workflow for running E2E tests triggered by PRs that targets our test infra.
It also includes necessary changes to tests in order to work with the new infra.
For the most part these are minor, with the one exception being the core E2E tests that were previously based on unittest; they have been converted to pytest to simplify the adoption of environment variable-based connection to the test resources. Unfortunately this means replacing a lot of self.assertEquals and similar with tests based on assert.

There is one potentially meaningful change in the sql client, where I found a test failing due to the server returning a list of headers, while the code is expecting a json string. After making this change, the test in question started passing, while no other tests failed, but I'm not certain this change is compatible with old versions of the DBR, so I will update it to be backwards compatible before merging.

Copy link

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

Copy link

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

Copy link
Collaborator

@yunbodeng-db yunbodeng-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrefurlan-db please review this PR.
@benc-db this is awesome. Let's do this!

Copy link

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

Copy link

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

Copy link

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

Copy link

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

Copy link

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

Copy link

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

formatting

Make sql client change backwards compatible, fix broken tests

fix the integration workflow and linting

fix broken tests

fix path

lint + install missing sqlalchemy library

skip cache for one run

fix integration so that it doesn't uninstall sqlalchemy

Signed-off-by: Ben Cassell <[email protected]>
@benc-db benc-db merged commit 60934b2 into main Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants