Skip to content

Ensure thrift field IDs are within range #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

vikrantpuppala
Copy link
Collaborator

Ensure thrift field IDs are within range

Test fails when limit is lowered:

Violations found:

  • TCLIService_types.js: Field ID 1281 exceeds maximum allowed value of 1199
  • TCLIService_types.js: Field ID 1282 exceeds maximum allowed value of 1199
  • TCLIService_types.js: Field ID 1283 exceeds maximum allowed value of 1199
  • TCLIService_types.js: Field ID 1284 exceeds maximum allowed value of 1199
  • TCLIService_types.js: Field ID 1285 exceeds maximum allowed value of 1199
  • TCLIService_types.js: Field ID 1286 exceeds maximum allowed value of 1199
  • TCLIService_types.js: Field ID 1287 exceeds maximum allowed value of 1199
  • TCLIService_types.js: Field ID 1288 exceeds maximum allowed value of 1199
  • TCLIService_types.js: Field ID 1289 exceeds maximum allowed value of 1199
  • TCLIService_types.js: Field ID 1296 exceeds maximum allowed value of 1199
    at Context. (tests/unit/thrift-field-id-validation.test.ts:47:13)
    at processImmediate (node:internal/timers:478:21)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant