removed clientId from userAgent string

[shivam2680]

Description

Issue reported: While migrating usage logic metric, userAgent tag sometimes emitted tokens.
This PR removes clientID from userAgent string thus mitigating possibility of such scenarios.

Testing

Unit tests modified to verify correct userAgentString is built.

[jackyhu-db]

this is not related to this PR, can you put it in a separated one?

[shivam2680]

sure.

[shivam2680]

changes done in PR

[kravets-levko]

@jackyhu-db @shivam2680 this fix is probably a mistake. clientId comes from user, and is intended to be used by users. It later appears in query history, so users may put some ID string there to know who submitted a query.

If by any chance you get some unwanted data there - it's not the library who did it, it's whatever that uses the library. So instead of removing this parameter, you had to check the code that uses the library.

Upd. Just to clarify: this parameter is a part of library's public interface. You cannot just remove it without incrementing major version number

[jackyhu-db]

@jackyhu-db @shivam2680 this fix is probably a mistake. clientId comes from user, and is intended to be used by users. It later appears in query history, so users may put some ID string there to know who submitted a query.

If by any chance you get some unwanted data there - it's not the library who did it, it's whatever that uses the library. So instead of removing this parameter, you had to check the code that uses the library.

Upd. Just to clarify: this parameter is a part of library's public interface. You cannot just remove it without incrementing major version number

Hi @kravets-levko the clientId should not be passed in the user agent as it may also include service principal ID, the user agent is mainly used to track the application/client (e.g node.js driver or some other app that uses the driver) instead of the individual client ID.

[kravets-levko]

@jackyhu-db clientId is exclusively for the user-agent. Service principal ID should be passed via oauthClientId

[jackyhu-db]

@jackyhu-db clientId is exclusively for the user-agent. Service principal ID should be passed via oauthClientId

@kravets-levko this clientId field may confuse the client. If it is only intended to be used for user-agent, we SHOULD name it explicitly as we did in other driver. See PySQL https://github.com/databricks/databricks-sql-python/blob/main/src/databricks/sql/client.py#L179

[kravets-levko]

@jackyhu-db Yes, I agree. But totally removing it is not an option. Renaming sounds more reasonable

[jackyhu-db]

@jackyhu-db Yes, I agree. But totally removing it is not an option. Renaming sounds more reasonable

I agreed. @shivam2680 can you create another change if you agree as well?