Change default environment to cloud-agnostic#1269
Open
hectorcast-db wants to merge 3 commits intomainfrom
Open
Change default environment to cloud-agnostic#1269hectorcast-db wants to merge 3 commits intomainfrom
hectorcast-db wants to merge 3 commits intomainfrom
Conversation
This change updates the DEFAULT_ENVIRONMENT from AWS-specific to Cloud.UNKNOWN, enabling better support for cloud-agnostic and unknown Databricks hosts. Key changes: - Add Cloud.UNKNOWN enum value - Change DEFAULT_ENVIRONMENT to use Cloud.UNKNOWN with no dns_zone - Make dns_zone Optional in DatabricksEnvironment - Add None-safety checks in is_azure/is_gcp/is_aws properties - Move DEFAULT_ENVIRONMENT to end of ALL_ENVS list for proper fallback - Add tests for UNKNOWN cloud environment behavior Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
tanmay-db
approved these changes
Feb 20, 2026
0612c46 to
a2c1959
Compare
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the SDK to be cloud-agnostic by removing cloud-specific detection and configuration. This includes updating the default environment handling and unifying Private Link error messages to work across all cloud providers without requiring cloud detection.
Changes
Environment Handling
Cloud.UNKNOWNenum value for cloud-agnostic hostsDEFAULT_ENVIRONMENTto useCloud.UNKNOWNwith nodns_zonedns_zoneoptional inDatabricksEnvironmentdataclassdns_zonevaluesDEFAULT_ENVIRONMENTto end ofALL_ENVSto ensure it's used as a fallback onlyPrivate Link Error Handling
_get_private_link_validation_error()_PrivateLinkInfoclasses and mappingMotivation
This change enables better support for:
Backward Compatibility
✅ This change is backward compatible:
is_azure,is_gcp, andis_awsproperties work correctly withCloud.UNKNOWN(all returnFalse)azure_workspace_resource_idstill correctly setsis_azure=Trueregardless of detected cloudTesting
test_unknown_cloud_environment_properties- verifies UNKNOWN cloud behaviortest_azure_resource_id_sets_is_azure_with_unknown_environment- verifies Azure resource ID override workstest_get_api_error[private_link_validation_error]- verifies unified Private Link error message