Open
Conversation
Signed-off-by: David Wilhelm <david.wilhelm@qaware.de>
f69d941 to
5cf23e6
Compare
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
WHAT: Fixes TypeError crash in RoundTrip.generate() when handling unparseable API error responses
and corrects the SDK issue tracker URL in error messages from databricks-sdk-go to databricks-sdk-py
WHY: When _BaseClient.do() receives string/bytes data, it wraps it in BytesIO for retry/seek support (line 167-169 in _base_client.py). If the API returns an unparseable error response, _unknown_error() creates a RoundTrip object to generate debug information. However, it doesn't pass raw=True, causing _redacted_dump() to be called with the BytesIO object instead of a string. This results in len(body) failing with TypeError: object of type '_io.BytesIO' has no len().
The fix checks if request.body is a string before calling _redacted_dump(). Non-string bodies (like BytesIO) are now logged as [raw stream], consistent with how raw streams are handled elsewhere in the codebase.
Fixes #1264
How is this tested?