Fix Config subclass attribute discovery and caching#1258
Open
jmahotiedu wants to merge 2 commits intodatabricks:mainfrom
Open
Fix Config subclass attribute discovery and caching#1258jmahotiedu wants to merge 2 commits intodatabricks:mainfrom
jmahotiedu wants to merge 2 commits intodatabricks:mainfrom
Conversation
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Config.attributes()to cache metadata per-class instead of inheriting another class's cache viahasattrConfigAttributedescriptors and annotations across the class MRO so subclasses inherit base config fieldsConfigsubclass can initialize with inherited fields even when attribute cache is coldThis addresses the behavior reported in #1069 where subclassed configs could ignore inherited fields and fail with default-auth errors.
Testing
uv run --no-project --with pytest --with requests --with google-auth --with protobuf --with requests-mock --with pyfakefs -- python -m pytest tests/test_core.py -k "config_can_be_subclassed or config_subclass_inherits_attributes"uv run --no-project --with pytest --with pytest-mock --with requests --with google-auth --with protobuf --with requests-mock --with pyfakefs -- python -m pytest tests/test_config.py