Remove unused acceptance MergeBundleConfig helper - #6644
Open
denik wants to merge 1 commit into
Open
Conversation
Added in #2809 (May 2025) to back an acceptance BundleConfig setting, but it is never invoked: nothing outside its own test calls MergeBundleConfig. Only bundle_config_test.go references it, so deadcode -test never flagged it. Co-authored-by: Isaac <no-reply@databricks.com>
janniklasrose
approved these changes
Sep 11, 2026
Collaborator
Integration test reportCommit: ab16b04
Top 3 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MergeBundleConfigwas added in #2809 (May 2025) to back an acceptanceBundleConfigsetting, but it's never invoked — nothing outside its own test calls it. Onlybundle_config_test.goreferences it, sodeadcode -test ./...doesn't flag it.This pull request and its description were written by Isaac.