Remove unused testdiff replacement helpers - #6643
Open
denik wants to merge 1 commit into
Open
Conversation
WithReplacementsMap/GetReplacementsMap (the context carrier for a ReplacementsContext) and the PrepareReplacementsNumber/ PrepareReplacementsTemporaryDirectory helpers were added in #2151 (Jan 2025) but are exercised only by testdiff's own tests; no other package uses them. Removes the now-orphaned numIdRegex/privatePathRegex with them. Keeps the live siblings (PrepareReplacementsUUID, PrepareReplacementSdkVersion). Co-authored-by: Isaac <no-reply@databricks.com>
janniklasrose
approved these changes
Sep 11, 2026
Collaborator
Integration test reportCommit: 6eb4a44
Top 4 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WithReplacementsMap/GetReplacementsMap(thecontext.Contextcarrier for aReplacementsContext) and thePrepareReplacementsNumber/PrepareReplacementsTemporaryDirectoryhelpers were added in #2151 (Jan 2025) but are exercised only by testdiff's own tests — no other package uses them. TheirnumIdRegex/privatePathRegexbecome orphaned and are removed too.The live siblings (
PrepareReplacementsUUID,PrepareReplacementSdkVersion, used by the acceptance harness) are kept.deadcode -test ./...doesn't flag any of this because testdiff's own tests keep it reachable.This pull request and its description were written by Isaac.