Remove never-wired folder writability check - #6638
Open
denik wants to merge 1 commit into
Open
Conversation
CheckWritable/CanWrite (plus the Writability type and the isWriteLevel/ userGroupNames helpers) were added in #5948 alongside the folder ACL consolidation, but no caller was ever wired up: the live path, ResolveFolderACL, is used by validate/folder_permissions.go only for Permissions.Compare, never for the write check. Reachable only from its own unit tests, so deadcode -test never flagged it. Keeps ResolveFolderACL and its walk-up-to-ancestor test. Co-authored-by: Isaac <no-reply@databricks.com>
Contributor
Waiting for approvalBased on git history, these people are best suited to review:
Eligible reviewers: Suggestions based on git history. See OWNERS for ownership rules. |
Collaborator
Integration test reportCommit: 02988ba
Top 3 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CheckWritable/FolderACL.CanWrite(with theWritabilitytype and theisWriteLevel/userGroupNameshelpers) were added in #5948 (Jul 2026) alongside the folder-ACL consolidation, but nothing ever called them. The live path,ResolveFolderACL, is used only byvalidate/folder_permissions.goforPermissions.Compare— never for the write check.Since the whole write-check API is reachable only from its own unit tests,
deadcode -test ./...doesn't flag it.ResolveFolderACLand its walk-up-to-ancestor test are kept.This pull request and its description were written by Isaac.