acceptance: replace DEV_VERSION with CLI_VERSION#5845
Open
denik wants to merge 1 commit into
Open
Conversation
Add a CLI_VERSION replacement that captures the exact version string of the CLI under test: - dev build (from source): run the binary to get its version - downloaded release (-useversion): use the known version string directly - arbitrary binary (-clipath): run the binary to get its version - inprocess mode: use build.GetInfo().Version from the test process Remove the DEV_VERSION regex replacement, which only matched the 0.0.0-dev* pattern and required separate handling for release builds. Co-authored-by: Isaac
Contributor
Approval status: pending
|
Collaborator
Integration test reportCommit: 5aa8958
8 interesting tests: 4 RECOVERED, 4 SKIP
Top 11 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
[DEV_VERSION]with[CLI_VERSION]in acceptance test output.The old regex only matched
0.0.0-dev*; the new replacement uses the actual version string from the binary under test, so it also works with downloaded releases and arbitrary binaries passed via-clipath.