catalogs: support isolation_mode, enable_predictive_optimization, owner fields#4819
Draft
catalogs: support isolation_mode, enable_predictive_optimization, owner fields#4819
Conversation
…owner support Adds three update-only fields to the catalog resource: - isolation_mode (ISOLATED/OPEN) - enable_predictive_optimization (ENABLE/DISABLE/INHERIT) - owner Since these fields cannot be set during creation (not in CreateCatalog API), DoCreate now calls a post-create update when any of them are non-empty. DoUpdate/DoUpdateWithID are refactored to share an applyUpdate helper. Adds acceptance tests: - isolation-mode: verifies fields are applied on create and can be updated - no-update-on-create: verifies no PATCH is called when these fields are absent Co-authored-by: Isaac
Add owner to ignore_remote_changes for catalogs — the API automatically sets it to the creator's username, causing drift when the user doesn't specify it. This also fixes the pre-existing no_drift failure for catalog.yml.tmpl. Add catalog_isolation_mode.yml.tmpl to the invariant test matrix to verify that isolation_mode and enable_predictive_optimization produce no drift after a successful deploy. Co-authored-by: Isaac
…nges Consistent with registered_models.owner — backend_defaults only suppresses drift when the user has never set the field (old/new are nil), while ignore_remote_changes suppresses drift even when user has explicitly set owner and it gets changed externally. Also exclude catalog_isolation_mode.yml.tmpl from migrate invariant test since catalog resources only work with direct deployment mode (same reason catalog.yml.tmpl is already excluded). Co-authored-by: Isaac
Since this test only runs on direct mode, there's no need for a per-engine filename. Use trace to embed the filtered catalog requests inline in output.txt. Clean up out.requests.txt in the cleanup trap in case the test fails before print_requests.py runs. Co-authored-by: Isaac
Co-authored-by: Isaac
…ruct) Co-authored-by: Isaac
Collaborator
|
Commit: 20a5753
19 interesting tests: 9 SKIP, 7 KNOWN, 2 flaky, 1 RECOVERED
Top 32 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Support isolation_mode, enable_predictive_optimization, owner fields on catalogs.
Why
User expect to be able to set those, they are supported by API (just not the create endpoint).
Tests
New acceptance & invariant fields.