direct: initialize "remote" in "changes" properly#4451
Merged
Conversation
Collaborator
|
Commit: 65fb54e
21 interesting tests: 7 KNOWN, 5 SKIP, 5 RECOVERED, 4 flaky
Top 50 slowest tests (at least 2 minutes):
|
denik
changed the title
denik
requested review from
andrewnester,
anton-107,
pietern and
shreyas-goenka
as code owners
pietern
approved these changes
Feb 5, 2026
andrewnester
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
When populating "remote" in "changes", look up value from remote state, do not assume it's equal to "new" from config.
Why
This is correct value for this field. The downside is that we can now have changes for parent and child fields separately in "changes" but it's not clear if it has any downides.
Tests
Existing tests.