direct: Include precise reason in the plan#4448
Merged
Conversation
denik
requested review from
andrewnester,
anton-107,
pietern and
shreyas-goenka
as code owners
Collaborator
|
Commit: da523fd
24 interesting tests: 7 KNOWN, 7 flaky, 5 SKIP, 5 RECOVERED
Top 50 slowest tests (at least 2 minutes):
|
andrewnester
approved these changes
Feb 5, 2026
pietern
reviewed
Feb 6, 2026
| lines.append("") | ||
| first = False | ||
| lines.append(f" # {behavior}:") | ||
| reason = f"spec:{behavior.lower()}" |
Contributor
There was a problem hiding this comment.
Nit: do we really need the spec: prefix?
The string after it is descriptive enough, IMO.
Contributor
Author
There was a problem hiding this comment.
I don't have a strong reason but it seems like knowing which config the setting comes from could be useful for debugging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Instead of marking all fields from the config as "builtin_rule", specify which field behaviour this decision is based on, e.g. "spec:output_only" or "spec:immutable". For manual reasons, there is "spec:" prefix.
Why
Seeing "builtin_rule" in the plan does not tell enough about this field.
Tests
Existing tests where plan is recorded.