Open
Conversation
shreyas-goenka
changed the title
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Commit: f0ec698
17 interesting tests: 7 KNOWN, 5 SKIP, 5 RECOVERED
Top 50 slowest tests (at least 2 minutes):
|
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
commented
Feb 5, 2026
| // OR | ||
| // make dbr-test | ||
| func TestDbrAcceptance(t *testing.T) { | ||
| if os.Getenv("DBR_ENABLED") != "true" { |
Contributor
Author
There was a problem hiding this comment.
DBR tests will run in a separate "env" and will not be a part of normal integration test run. This option enables that.
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
changed the title
shreyas-goenka
changed the title
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
added a commit
that referenced
this pull request
Feb 6, 2026
## Changes This PR updates the CLI to use the FUSE to read and write notebooks instead of the workspace APIs, when the DBR version is serverless 2.5+. This has the following benefits: 1. Much faster bundle deployments / summaries etc for DABs in the workspace. 2. Fixes commands like `bundle generate --bind` which were previously failing on DABs in the workspace due to both the workspace APIs and FUSE being used simultaneously. 3. Enables running tests on DBR. With the previous logic, running tests on DBR would fail because of mixing workspace API access and FUSE access. ## Tests Manually verified that both bundle deploy / bundle generate continue to work correctly on DBR. Also verified that `bundle generate --bind` works on DBR. Acceptance tests will be added once #4416 lands. ---- bundle generate --bind works, i.e. all notebooks are written successfully via FUSE: <img width="821" height="293" alt="Screenshot 2026-02-05 at 23 30 08" src="https://github.com/user-attachments/assets/55d61b57-39a7-4119-8275-f38df17c6aba" /> ---- bundle deploy works, for all sorts of notebooks, i.e. they are read correctly. <img width="819" height="232" alt="Screenshot 2026-02-05 at 23 30 15" src="https://github.com/user-attachments/assets/badc91ae-1fee-41e8-9429-4cc8b6d2be97" /> ---- This was tested and run on serverless `client.2.5` (standard v2). The UI does not allow me to select a minor version so I could not test other client.2 versions like 2.4. That's why we only use FUSE from 2.5 onwards. In practice this is fine because customers wil also likely be using `2.5` or above it they are on serverless.
shreyas-goenka
requested review from
andrewnester,
anton-107,
denik and
pietern
as code owners
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This:
RecordRequest = truebecause serverless does not allow localhost connections.builds upon #4450
Logs from the test run:
The CI job will be added once the runner is merged.