-
Notifications
You must be signed in to change notification settings - Fork 118
Suppress xdg-open warnings in auth login command
#3991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Override browser package Stderr to suppress xdg-open error messages - Improve browser instruction message formatting - Add newline separation for better output readability
Collaborator
|
Commit: 36217de
12 failing tests:
Top 23 slowest tests (at least 2 minutes):
|
shreyas-goenka
approved these changes
Nov 24, 2025
andrewnester
approved these changes
Nov 24, 2025
github-merge-queue bot
pushed a commit
to databricks/databricks-sdk-go
that referenced
this pull request
Nov 24, 2025
## What changes are proposed in this pull request? The error case missed a newline. I took the opportunity to rephrase the message. ## How is this tested? Before: ``` $ databricks auth login --profile myprofile /usr/bin/xdg-open: 869: www-browser: not found /usr/bin/xdg-open: 869: links2: not found /usr/bin/xdg-open: 869: elinks: not found /usr/bin/xdg-open: 869: links: not found /usr/bin/xdg-open: 869: lynx: not found /usr/bin/xdg-open: 869: w3m: not found xdg-open: no method available for opening 'https://...' Please open https://... in the browser to continue authenticationProfile myprofile was successfully saved ``` After (includes databricks/cli#3991): ``` $ databricks auth login --profile myprofile Please continue the authentication process in your browser: https://... Profile myprofile was successfully saved ``` <!-- NO_CHANGELOG=true //-->
Collaborator
|
Commit: 4f78236
51 failing tests:
Top 50 slowest tests (at least 2 minutes):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Suppress
xdg-openwarnings when opening a browser forauth login.Why
Before:
After (includes databricks/databricks-sdk-go#1334):
Tests
Manual only.