Upgrade Go SDK to v0.91.0 #3944
Closed
+136
−90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anton-107
requested review from
a team,
andrewnester,
denik,
pietern and
shreyas-goenka
as code owners
anton-107
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
9 failing tests:
Top 29 slowest tests (at least 2 minutes):
|
| var getReq settings.GetCspEnablementAccountSettingRequest | ||
|
|
||
| cmd.Flags().StringVar(&getReq.Etag, "etag", getReq.Etag, `etag used for versioning.`) | ||
| cmd.Flags().StringVar(&getReq.Etag, "etag", getReq.Etag, `etag used for versioning. Wire name: 'etag'.`) |
Contributor
There was a problem hiding this comment.
We have this new "Wire name: '...'" string now everywhere, doesn't look intended / needed for CLI
shreyas-goenka
approved these changes
Nov 18, 2025
Contributor
There was a problem hiding this comment.
Intentionally being commited? I think we should remove it.
Contributor
Author
|
closed in favor of #3948 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Why
Tests