Added support for --bind flag in bundle generate
#3782
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewnester
requested review from
anton-107,
denik,
pietern and
shreyas-goenka
as code owners
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
73 failing tests:
|
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
pietern
reviewed
Oct 24, 2025
| @@ -0,0 +1,26 @@ | |||
| # This test is using a workspace import API to load a notebook file. | |||
| # This API has a logic on how to accept notebook files and distinguishes them from regular python files. | |||
| # To succeed locally we would need to replicate this logic in the fake_workspace | |||
There was a problem hiding this comment.
Certainly, there are a bunch of other tests that need this, worth doing this as a separate PR
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
pietern
reviewed
Oct 27, 2025
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
pietern
approved these changes
Oct 27, 2025
Comment on lines
+26
to
+33
| Two-step workflow (manual bind): | ||
| 1. Generate: databricks bundle generate job --existing-job-id 123 --key my_job | ||
| 2. Bind: databricks bundle deployment bind my_job 123 | ||
| 3. Deploy: databricks bundle deploy | ||
| One-step workflow (automatic bind): | ||
| 1. Generate and bind: databricks bundle generate job --existing-job-id 123 --key my_job --bind | ||
| 2. Deploy: databricks bundle deploy |
There was a problem hiding this comment.
nit:
Suggested change
| Two-step workflow (manual bind): | |
| 1. Generate: databricks bundle generate job --existing-job-id 123 --key my_job | |
| 2. Bind: databricks bundle deployment bind my_job 123 | |
| 3. Deploy: databricks bundle deploy | |
| One-step workflow (automatic bind): | |
| 1. Generate and bind: databricks bundle generate job --existing-job-id 123 --key my_job --bind | |
| 2. Deploy: databricks bundle deploy | |
| Three-step workflow (manual bind): | |
| 1. Generate: databricks bundle generate job --existing-job-id 123 --key my_job | |
| 2. Bind: databricks bundle deployment bind my_job 123 | |
| 3. Deploy: databricks bundle deploy | |
| Two-step workflow (automatic bind): | |
| 1. Generate and bind: databricks bundle generate job --existing-job-id 123 --key my_job --bind | |
| 2. Deploy: databricks bundle deploy |
| // This function is shared between the bind command and generate commands with --bind flag. | ||
| func BindResource(cmd *cobra.Command, resourceKey, resourceId string, autoApprove, forceLock bool) error { | ||
| ctx := cmd.Context() | ||
| b := utils.ConfigureBundleWithVariables(cmd) |
There was a problem hiding this comment.
Note: This means functions like root.MustConfigureBundle end up being called twice on the command struct.
| } | ||
|
|
||
| if !exists { | ||
| return fmt.Errorf("%s with an id '%s' is not found", resource.ResourceDescription().SingularName, resourceId) |
There was a problem hiding this comment.
grammer nit:
Suggested change
| return fmt.Errorf("%s with an id '%s' is not found", resource.ResourceDescription().SingularName, resourceId) | |
| return fmt.Errorf("%s with an id '%s' was not found", resource.ResourceDescription().SingularName, resourceId) |
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
deco-sdk-tagging bot
added a commit
that referenced
this pull request
Oct 29, 2025
## Release v0.275.0 ### Notable Changes * Python support for Databricks Asset Bundles is now generally available. ### CLI * Remove `inplace` mode for the `--progress-format` flag ([#3811](#3811)) * Remove `json` mode for the `--progress-format` flag ([#3812](#3812)) * Deprecate the `--progress-format` flag ([#3819](#3819)) ### Bundles * Add support for `--bind` flag in `bundle generate` ([#3782](#3782)) * Add `pydabs` template replacing `experimental-jobs-as-code` template ([#3806](#3806)) * You can now use the top-level `python` section instead of `experimental/python` ([#3540](#3540))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added support for --bind flag in
bundle generateWhy
This allows us to generate and bind the resources using one command instead of 2 separate commands.
Tests
Added an acceptance test