Gracefully exit when terminated mid deploy / destroy #3758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
pietern
reviewed
Oct 14, 2025
| go func() { | ||
| sig := <-sigChan | ||
| // Stop listening for more signals | ||
| signal.Stop(sigChan) |
There was a problem hiding this comment.
The main routine is still running at this point. We need to make sure it is terminated and wait for that termination before releasing the lock and terminating.
We could return a new context from this function and cancel it when the signal is received.
That doesn't ensure we wait for completion/termination and could be handled similarly.
19 failing tests:
|
denik
reviewed
Oct 14, 2025
| title "A creation request for job1 should be recorded in the requests file. No request for job2 should exist since the process was terminated mid deployment." | ||
| trace cat out.requests.txt | jq 'select(.method == "POST" and (.path | contains("/api/2.2/jobs/create")))' | ||
|
|
||
| rm out.requests.txt |
There was a problem hiding this comment.
would be nice to record 'bundle plan' after interrupted deploy/destroy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Why
Tests