Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(query): add placeholder parser #17481

Merged
merged 15 commits into from
Feb 20, 2025

Conversation

sundy-li
Copy link
Member

@sundy-li sundy-li commented Feb 19, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

chore(query): add placeholder parser

We used to think it's useless, but now we have decided to add it in the parser.

related to databendlabs/bendsql#583

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Feb 19, 2025
@sundy-li sundy-li requested a review from b41sh February 19, 2025 03:08
@b41sh b41sh force-pushed the placeholder-parser branch from bd38bb3 to de820b4 Compare February 19, 2025 07:07
@b41sh b41sh force-pushed the placeholder-parser branch from de820b4 to f3c9f0c Compare February 19, 2025 07:31
@sundy-li sundy-li merged commit 90aa255 into databendlabs:main Feb 20, 2025
76 checks passed
@sundy-li sundy-li deleted the placeholder-parser branch February 20, 2025 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants