Skip to content

ISSUE-1470: remove common/allocators #1472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/actions-rs/grcov.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ ignore:
- "*/exception/*"
- "*/tests/*"
- "*/arrow/*"
- "*/allocators/*"
- "*/building/*"
- "*/profiling/*"
- "*/tracing/*"
Expand Down
71 changes: 0 additions & 71 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
[workspace]
members = [
# Common
"common/allocators",
"common/arrow",
"common/building",
"common/datablocks",
Expand Down
32 changes: 0 additions & 32 deletions common/allocators/Cargo.toml

This file was deleted.

47 changes: 0 additions & 47 deletions common/allocators/src/lib.rs

This file was deleted.

2 changes: 0 additions & 2 deletions query/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,10 @@ path = "src/bin/datafuse-benchmark.rs"
[features]
default = ["simd"]
simd = ["common-arrow/simd"]
allocator = ["common-allocators/snmalloc-alloc"]

[dependencies]
# Workspace dependencies
common-arrow = { path = "../common/arrow" }
common-allocators = { path = "../common/allocators" }
common-datablocks = { path = "../common/datablocks" }
common-datavalues = { path = "../common/datavalues" }
common-exception = { path = "../common/exception" }
Expand Down
3 changes: 0 additions & 3 deletions query/src/bin/datafuse-benchmark.rs
Original file line number Diff line number Diff line change
Expand Up @@ -125,9 +125,6 @@ impl Stats {

#[tokio::main]
async fn main() -> Result<()> {
// Use customize malloc.
let _ = common_allocators::init();

// First load configs from args.
let conf = Config::load_from_args();
let address = format!("{}:{}", conf.host, conf.port)
Expand Down
6 changes: 1 addition & 5 deletions query/src/bin/datafuse-query.rs
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,6 @@ use log::info;

#[tokio::main]
async fn main() -> Result<(), Box<dyn std::error::Error>> {
// Use customize malloc.
let malloc = common_allocators::init();

// First load configs from args.
let mut conf = Config::load_from_args();

Expand All @@ -59,9 +56,8 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> {

info!("{:?}", conf);
info!(
"DatafuseQuery v-{}, Allocator: {}",
"DatafuseQuery v-{}",
*datafuse_query::configs::config::FUSE_COMMIT_VERSION,
malloc
);

let cluster = Cluster::create_global(conf.clone())?;
Expand Down